Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #1196 Multi Source Inventory support #1202

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Nov 27, 2018

Created an additional module with a somewhat evocative name, but I'm not so sure about it anymore, since \Magento\CatalogInventory\Api\StockRegistryInterface and \Magento\CatalogInventory\Api\StockConfigurationInterface are cleared marked as deprecated (see full list in https://devdocs.magento.com/guides/v2.3/inventory/catalog-inventory-replacements.html).

Having the changes directly in elasticsuite-catalog would remove the need for the extra interface I had to introduce.

@rbayet rbayet requested a review from romainruaud November 27, 2018 15:55
@rbayet rbayet force-pushed the feature_1196_adding_msi_support branch from dc52527 to f319c8d Compare November 27, 2018 16:16
@romainruaud
Copy link
Collaborator

Impressive ! seems it was pretty easy after all :)

I'm not sure either about the additional module :

  • implementation looks quite transparent to me, and could probably be done directly on the ElasticsuiteCatalog module directly.

  • in any cases, hoping for BC with such huge changes, by having an additional module which is meant to be disabled on 2.2.x is kinda risky (could double the maintenance time), in addition of being quite ugly and not easily understandable.

  • the Interface for Stock data fetching suits me well, we can keep it, it will allow people to write their own and switch the implementation nicely, so we can keep it.

Let's talk about it together today, but we'll probably go for a direct implementation on ElasticsuiteCatalog, and having a 2.7.0 major version which requires Magento >= 2.3.0.

@rbayet rbayet force-pushed the feature_1196_adding_msi_support branch 2 times, most recently from 8d08177 to 4b9d318 Compare November 28, 2018 16:49
@rbayet rbayet force-pushed the feature_1196_adding_msi_support branch from 4b9d318 to 010f0a8 Compare November 28, 2018 17:00
@rbayet rbayet merged commit 15eab72 into Smile-SA:master Nov 28, 2018
@rbayet rbayet deleted the feature_1196_adding_msi_support branch March 1, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants