fix mdns crash on scoped IPv6 link-local #4
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change the library will always crash with "SocketException: no route to host" when used on IPv6 interface with a scoped address e.g.[FE80::1%1]. The root cause was because the multicast address for IPv6 didn't specify a scope ID for such cases. This commit fixes it by first checking if the local endpoint is an IPv6 link local, if true, it will create and use a scoped multicast address for mdns. The resulting multicast address is then stored for reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
Before this change the library will always crash with
SocketException: no route to hostwhen mdns is used on IPv6 interface with a scoped address e.g.[FE80::1%1]The root cause was because the multicast address for IPv6 didn't specify a scope ID for such cases.
This commit fixes it by first checking if the local endpoint is an IPv6 link local, if true, then it will create and use a scoped multicast address. The resulting multicast address is then stored for reuse.