Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWPROT-8953: Release 1.7.0 #35

Merged
merged 4 commits into from
Feb 14, 2025
Merged

SWPROT-8953: Release 1.7.0 #35

merged 4 commits into from
Feb 14, 2025

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Feb 12, 2025 •
edited
Loading

Change

To be merged after:

Is anything more missing ?

Checklist

@rzr rzr marked this pull request as draft February 12, 2025 18:01
@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025

https://github.com/SiliconLabs/UnifySDK/releases/tag/ver_1.7.0 is released

Couple of patches to land before merging and tagging this one

rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
2fab724 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr marked this pull request as ready for review February 13, 2025 14:33
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
c6a2e6b 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 6c277b7 to c6a2e6b Compare February 13, 2025 14:37
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
3e6e2fc 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from c6a2e6b to 3e6e2fc Compare February 13, 2025 14:49
silabs-JulienT
silabs-JulienT requested changes Feb 13, 2025
View reviewed changes
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: zpc: rust: Upgrade shlex to version 1.3.0
eecb19a 
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: build: Add hints in helper script
da976f7 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
e5a2d31 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 3e6e2fc to e5a2d31 Compare February 13, 2025 17:28
@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025

updated PR with 2 more patches for RC9 for smoktesting, to be merged tomorrow.

rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
5475d61 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from e5a2d31 to 5475d61 Compare February 13, 2025 17:48
rzr added 2 commits February 13, 2025 19:42
@rzr
SWPROT-8953: docs: Use git describe --tag for generating zpc docs
b306ae7 
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr
SWPROT-8953: zpc: rust: Upgrade shlex to version 1.3.0
7df8529 
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: build: Add hints in helper script
cdbc7ad 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
4e8133b 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 5475d61 to 4e8133b Compare February 13, 2025 18:43
@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025

pages will be generated with the right tag "Git Version string: ***-RC10" i am testing this and will smoktest assets when out, and then we can merge and tag

@rzr
Copy link
Collaborator Author

rzr commented Feb 13, 2025 •
edited
Loading

ver_1.7.0-RC10 appears at:

https://siliconlabssoftware.github.io/z-wave-protocol-controller/doc/introduction.html

I found the root cause, it was caused by github action there is a PR pending... it can be tracked after release

Testables are available at:

https://github.com/SiliconLabsSoftware/z-wave-protocol-controller/releases/tag/ver_1.7.0-RC10

Let me cook an other RC11 with the image-provider and we can release tommorow

rzr added 2 commits February 13, 2025 22:51
@rzr
SWPROT-8953: build: Add hints in helper script
848eb02 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr
SWPROT-8953: Release 1.7.0
b64f9a8 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@rzr rzr force-pushed the release/review/main branch from 4e8133b to b64f9a8 Compare February 13, 2025 21:52
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: docs: Use git describe --tag for generating zpc docs
9e21708 
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: zpc: rust: Upgrade shlex to version 1.3.0
df6eee3 
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: build: Add hints in helper script
b15a660 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 13, 2025
@rzr
SWPROT-8953: Release 1.7.0
fdd5eda 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: docs: Use git describe --tag for generating zpc docs
6b96454 
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: zpc: rust: Upgrade shlex to version 1.3.0
2097e3b 
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: build: Add hints in helper script
1e39194 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: Release 1.7.0
47e7ecb 
Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@silabs-peterb
Copy link
Collaborator

I tested this version with an inclusion on my system:

My setup:
Docker under WSL
Controller: brd4205b -> SAPI 7.19
DUT: brd4205b -> Doorlock from 24q4 release
Region: US

Looks good on my side!

@rzr
Copy link
Collaborator Author

rzr commented Feb 14, 2025

Great thank you all for review and time , for the record @silabs-aydogane setup (built on macos)

Controller: brd4205b -> Controller NCP SAPI from 24q4 release
DUT: brd4205b -> Switch on/off from 24q4 release
Region: EU
OS: OSX native (edited)

@rzr rzr merged commit 7411581 into main Feb 14, 2025
1 check passed
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: docs: Use git describe --tag for generating zpc docs
cf156c9 
For some reasons it was using an older annotated tag (RC0)
I didnt investigate much, but I believe it prefer tags in branches (main)
which is a good practice,
If confirmed we can switch back to the default describe
and enforce tags in branches.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: zpc: rust: Upgrade shlex to version 1.3.0
a24a4d3 
Multiple issues involving quote API in shlex

Cargo files were unlocked and only this dep update was applied.

I don't know the impact of the change, let me try CI check
and smoke test a RC binary.

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 14, 2025
@rzr
SWPROT-8953: build: Add hints in helper script
08842e7 
This part is not yet documented in docs,
it will be done after the deduplication of UnifySDK

For the record the whole zpc code can be built using this oneliner:

  time docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main # 17min

Origin: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
@rzr
SWPROT-8953: ci: Pull annotated tag
3feeb5d 
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
@rzr
SWPROT-8953: ci: Pull annotated tag
0150f74 
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: SiliconLabsSoftware#42
Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit to rzr/z-wave-protocol-controller that referenced this pull request Feb 18, 2025
@rzr
SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version
de9c194 
Origin: SiliconLabsSoftware#42
Relate-to: Relate-to: SiliconLabsSoftware#35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 19, 2025
@rzr
SWPROT-8953: ci: Pull annotated tag
414026a 
After further investigations, the reason that script failed to use
the git describe in github it because of a bug in related github action

Relate-to: actions/checkout#2081
Origin: #42
Relate-to: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
rzr added a commit that referenced this pull request Feb 19, 2025
@rzr
SWPROT-8953: cmake: Drop vers_1.7.0 hardcoded version
7cfac50 
Origin: #42
Relate-to: Relate-to: #35
Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silabs-JulienT silabs-JulienT silabs-JulienT approved these changes

@Thomasdjb Thomasdjb Thomasdjb approved these changes

@silabs-aydogane silabs-aydogane silabs-aydogane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rzr @silabs-peterb @silabs-JulienT @Thomasdjb @silabs-aydogane