-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpc: Import libs2 changes from latest snapshot and tag version #50
Comments
…nder ThirdParty directory. libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit 0118850059796a045285e5702a2d713c6f19352f) Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit bd9c072ab205d3745c64b09ccb9646fef7923abd) Last-Update: 2025-04-04 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nder ThirdParty directory. libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit 0118850059796a045285e5702a2d713c6f19352f) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
(cherry picked from commit bd9c072ab205d3745c64b09ccb9646fef7923abd) Last-Update: 2025-04-04 Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Previous changes are not atomic (because comming from different context) they are now isolated and grouped in same PR. Bug-ZPC: #50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nder ThirdParty directory. libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: #50 Forwarded: #51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: #50 Origin: #51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Previous changes are not atomic (because comming from different context) they are now isolated and grouped in same PR. Bug-ZPC: #50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nder ThirdParty directory (SiliconLabsSoftware#51) libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…are#51) (cherry picked from commit 0118850059796a045285e5702a2d713c6f19352f) Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ath (SiliconLabsSoftware#51) (cherry picked from commit bd9c072ab205d3745c64b09ccb9646fef7923abd) Last-Update: 2025-04-04 Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nder ThirdParty directory (#51) libS2 now depends on two pathes from Zwave Stack : - ZWAVE_INCLUDE_DIR for all API include files - ZWAVE_CLASSCMD_DIR for ZW_classcmd.h file (cherry picked from commit 085d0c280bf0e187327f6c3e9542693eb097f54b) Relate-to: #50 Forwarded: #51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
For the record following changes were shared: bd9c072a SWPROT-9264: Update libs2 Jenkinsfile with ZW_classcmd.h new path 01188500 SWPROT-9272: Correct NLS Support advertising 085d0c28 SWPROT-9264: Store ZW_classcmd.h in a generated subdirectory under ThirdParty directory. Relate-to: #50 Origin: #51 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…absSoftware#57) (cherry picked from commit 299c26d472c31e68f0d38734aee17304aa1690b9) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…liconLabsSoftware#57) (cherry picked from commit 76628f725482047b6977f49a039aa4a0cba9c81f) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…iliconLabsSoftware#57) (cherry picked from commit 5eec29c36e46c0069058e64dbd108cce51c1f35f) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…liconLabsSoftware#57) removed unity_print as it's useless on x86 and unit tests only run on x86 nowadays (cherry picked from commit cc1e9bd53e9abeab1702212a33182192663cad81) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…ROSS_SYSTEM_DIR (SiliconLabsSoftware#57) (cherry picked from commit 83e42131435e21ab70b2f77437a6befe4c4ac4c6) Forwarded: SiliconLabsSoftware#57 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…as outdated (#57) remove unity bundled with TestFramwork as it was outdated, we are now using the unity bundled with cmock in ThirdParty/cmock/vendor/unity. libs2 standalone unit tests were updated as well. (cherry picked from commit ba375ff2e7580da7a716697a5d39922adc09e888) Forwarded: #57 Relate-to: #50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…er.py (#57) the Docker image running as agent in UnifySDK CI does not have the python executable installed, this change prevents this kind of error from happening again (cherry picked from commit ccbd3fb30b7edfa51db0553f8df90c84a3a54184) Forwarded: #57 Relate-to: #50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
) Observed issue on ver_1.7.0-27-g1302b2a5 was: docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main unable to prepare context: unable to 'git clone' to temporary context directory: \ error initializing submodules: fatal: No url found for submodule path \ 'applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock' in .gitmodules This was done using: git submodule add --force \ https://github.com/throwtheswitch/cmock \ applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock git -C applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock \ checkout v2.5.3-g9d092898 Relate-to: #57 (comment) Relate-to: #50 Origin: #59 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
) Observed issue on ver_1.7.0-27-g1302b2a5 was: docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main unable to prepare context: unable to 'git clone' to temporary context directory: \ error initializing submodules: fatal: No url found for submodule path \ 'applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock' in .gitmodules This was done using: git submodule add --force \ https://github.com/throwtheswitch/cmock \ applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock git -C applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock \ checkout v2.5.3-g9d092898 Relate-to: #57 (comment) Relate-to: #50 Origin: #59 Relate-to: #60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…iliconLabsSoftware#59) Observed issue on ver_1.7.0-27-g1302b2a5 was: docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main unable to prepare context: unable to 'git clone' to temporary context directory: \ error initializing submodules: fatal: No url found for submodule path \ 'applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock' in .gitmodules This was done using: git submodule add --force \ https://github.com/throwtheswitch/cmock \ applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock git -C applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock \ checkout v2.5.3-g9d092898 Relate-to: SiliconLabsSoftware#57 (comment) Relate-to: SiliconLabsSoftware#50 Origin: SiliconLabsSoftware#59 Relate-to: SiliconLabsSoftware#60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
) Observed issue on ver_1.7.0-27-g1302b2a5 was: docker build https://github.com/SiliconLabsSoftware/z-wave-protocol-controller.git#main unable to prepare context: unable to 'git clone' to temporary context directory: \ error initializing submodules: fatal: No url found for submodule path \ 'applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock' in .gitmodules This was done using: git submodule add --force \ https://github.com/throwtheswitch/cmock \ applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock git -C applications/zpc/components/zwave/zwave_transports/s2/libs/zw-libs2/TestFramework/cmock \ checkout v2.5.3-g9d092898 Relate-to: #57 (comment) Relate-to: #50 Origin: #59 Relate-to: #60 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
…nLabsSoftware#53) Merge in UIC/uic from task/ayersoz/SWPROT-9246-nls-node-list-get-report-implementation to z-wave/main [Philippe Coval] That change was split libs2 changes are in previous commits Last-update: 2025-03-05 Relate-to: SiliconLabsSoftware#50 Forwarded: SiliconLabsSoftware#53 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Merge in UIC/uic from task/ayersoz/SWPROT-9320-controller-nls-state-storage to z-wave/main (cherry picked from commit 7a63883eb991f0f8cbbb663df8802be0764ec6e5) Last-Update: 2025-03-05 Forwarded: SiliconLabsSoftware#54 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
Merge in UIC/uic from task/ayersoz/SWPROT-9320-controller-nls-state-storage to z-wave/main (cherry picked from commit 7a63883eb991f0f8cbbb663df8802be0764ec6e5) Last-Update: 2025-03-05 Forwarded: SiliconLabsSoftware#54 Relate-to: SiliconLabsSoftware#50 Signed-off-by: Philippe Coval <philippe.coval@silabs.com>
@silabs-aydogane job is done, we might want to tag a version just before the refactoring, would this makes sense to you ? |
Ok let's do it. |
I will wait the first refactoring change to be ready to merge, lets track that release task: One remark before closing, maybe we will have to consider about code formatting rules, zpc/unify is using clang format and libs2 code to be formatted using uncrustify... this divergence could be annoying, feel free to file an issue when needed. |
Bug-SiliconLabs: SWPROT-9361
API breakage observed, I will issue a PR to reproduce
cc: @silabs-aydogane
Related changes to be merged in following order:
check NEWS.md file for tracking context
For the record I observe the only changes with
The text was updated successfully, but these errors were encountered: