Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing library dependencies. #113

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Fix missing library dependencies. #113

merged 2 commits into from
Apr 30, 2020

Conversation

gzahl
Copy link
Contributor

@gzahl gzahl commented Apr 26, 2020

I tried building the ina219 example, but some library dependencies were missing. That is fixed by this pull request.
Btw. thanks for this great library!

Copy link
Collaborator

@ba58smith ba58smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how you add a library to a PlatformIO Project. You do it in the platformio.ini file. That's what PR #110 does, so this PR is unnecessary.

@ba58smith ba58smith closed this Apr 26, 2020
@ba58smith
Copy link
Collaborator

ba58smith commented Apr 29, 2020

@gzahl - Well, apparently that IS how you add a library to a PlatformIO project, if it's a library. I just learned this today. My apologies. I will reopen this, and merge it.

@ba58smith ba58smith reopened this Apr 29, 2020
@ba58smith ba58smith merged commit 519da59 into SignalK:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants