fix: Filters, Template Manager, Dynamic chaarcters list #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
snobbee
changed the title
Deploying prosper-docs with
|
| Latest commit: |
0d66c7c
|
| Status: | ⚡️ Build in progress... |
Deploying prosper-docs with
|
| Latest commit: |
0d66c7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://461fc3be.realityspiral-dgb.pages.dev |
| Branch Preview URL: | https://filterandtemplate.realityspiral-dgb.pages.dev |
Deploying agents-docs with
|
| Latest commit: |
0d66c7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f1856aac.realityspiral.pages.dev |
| Branch Preview URL: | https://filterandtemplate.realityspiral.pages.dev |
Deploying prosper-docs with
|
| Latest commit: |
3f5d39f
|
| Status: | ⚡️ Build in progress... |
Deploying prosper-docs with
|
| Latest commit: |
3f5d39f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://697a5d15.realityspiral-dgb.pages.dev |
| Branch Preview URL: | https://filterandtemplate.realityspiral-dgb.pages.dev |
Deploying agents-docs with
|
| Latest commit: |
3f5d39f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f21bffd1.realityspiral.pages.dev |
| Branch Preview URL: | https://filterandtemplate.realityspiral.pages.dev |
Comment on lines
+1005
to
+1007
| router.get("/traces/unique-runs", async (req, res) => { | ||
| getUniqueRuns(req, res); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 7 days ago
To fix the problem, we need to introduce rate limiting to the Express application. The best way to do this is by using the express-rate-limit package, which allows us to set up a rate limiter and apply it to the routes that perform expensive operations.
- Install the
express-rate-limitpackage. - Import the
express-rate-limitpackage in the file. - Set up a rate limiter with appropriate configuration (e.g., maximum of 100 requests per 15 minutes).
- Apply the rate limiter to the routes that perform expensive operations, such as the route handler on line 1005.
Suggested changeset
2
clients/client-direct/src/api.ts
| @@ -5,2 +5,3 @@ | ||
| import express from "express"; | ||
| import rateLimit from "express-rate-limit"; | ||
| import type { Router } from "express"; | ||
| @@ -42,2 +43,7 @@ | ||
|
|
||
| const limiter = rateLimit({ | ||
| windowMs: 15 * 60 * 1000, // 15 minutes | ||
| max: 100, // limit each IP to 100 requests per windowMs | ||
| }); | ||
|
|
||
| interface UUIDParams { | ||
| @@ -1004,3 +1010,3 @@ | ||
| */ | ||
| router.get("/traces/unique-runs", async (req, res) => { | ||
| router.get("/traces/unique-runs", limiter, async (req, res) => { | ||
| getUniqueRuns(req, res); |
clients/client-direct/package.json
Outside changed files
This fix introduces these dependencies
| Package | Version | Security advisories |
| express-rate-limit (npm) | 7.5.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Comment on lines
+1098
to
+1100
| router.get("/templates/characters", async (req, res) => { | ||
| getCharacters(req, res); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
snobbee
approved these changes
Feb 21, 2025
monilpat
pushed a commit
that referenced
this pull request
Feb 22, 2025
* Filters, Template Manager, Dynamic chaarcters list * fix(tracer): fix swagger not diplaying endpoints, removed duplicated routes --------- Co-authored-by: Snobbish Bee <125891987+snobbee@users.noreply.github.com>
monilpat
added a commit
that referenced
this pull request
Feb 23, 2025
) * only sell what you have bought * add trade specific pnl * chore: add pre commit auto formatting (#37) * docs: Update TG on website (#39) Update TG on website * feat: Add provider for token address + staking instructions (#40) * token address + staking instructions * 2 * address comments * comments * docs: Update PROSPER token README.md (#43) * Update README.md * Add files via upload * Update Prosper token README.md Added image from staking website. * Update PROSPER token README.md described option for RSP holders to get PROSPER thotugh staking RSP/ETH * docs: Link to Prosper website from main RS website (#42) Link to Prosper website from main RS website * docs: Add stakeprosper.com link in coverpage (#41) Update _coverpage.md * chore: fix biome errors (#45) * fix: Filters, Template Manager, Dynamic chaarcters list (#38) * Filters, Template Manager, Dynamic chaarcters list * fix(tracer): fix swagger not diplaying endpoints, removed duplicated routes --------- Co-authored-by: Snobbish Bee <125891987+snobbee@users.noreply.github.com> * Update index.ts with bridging instructions (#46) * only sell what you have bought * add trade specific pnl * clean up * add wiining streak * formatting --------- Co-authored-by: Snobbish Bee <125891987+snobbee@users.noreply.github.com> Co-authored-by: Tim <70578108+TimKozak@users.noreply.github.com> Co-authored-by: mihai169 <42907887+mihai169@users.noreply.github.com> Co-authored-by: Master X <sohaibanwaar36@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risks
Low – Changes are scoped to filtering, template management, and character listing.
Potential risk: UI regressions in template selection.
Mitigation: Manual and automated testing conducted.
Background
What does this PR do?
Fixes the filter issue and Template Manager.
Improves the dynamic character list retrieval from the API.
Ensures smooth selection and updates of templates for characters.
What kind of change is this?
✅ Bug Fix (resolves filtering issue)
✅ Improvement (better character management)
✅ Feature (dynamic character selection)
Documentation changes needed?
✅ No documentation changes required.