Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy Rails app for testing Tapioca LSP #2099

Closed
wants to merge 3 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 27, 2024

Part of https://github.com/Shopify/team-ruby-dx/issues/1327

The command I used. I inclued --api to skip the views, layouts, JS, etc.

rails new dummy --minimal --skip-ci --skip-rubocop --skip-git --skip-bundle --api --skip-tests --skip-keeps --no-solid --skip-kamal --skip-thruster

Then I removed some files that aren't relevant for our needs (see seperate commit).

We may need to refine it further, but let's gets this initial version merged first, then future chnages will be easier to review.

@andyw8 andyw8 added the chore label Nov 27, 2024
@andyw8 andyw8 marked this pull request as ready for review November 27, 2024 21:36
@andyw8 andyw8 requested a review from a team as a code owner November 27, 2024 21:36
@andyw8 andyw8 force-pushed the andyw8/add-dummy-rails-app branch 2 times, most recently from 09541f8 to 6bc6aef Compare November 27, 2024 21:48
gem "tzinfo-data", platforms: %i[ windows jruby ]

# Deploy this application anywhere as a Docker container [https://kamal-deploy.org]
gem "kamal", require: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(even with --skip-kamal this still shows up)

# See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
gem "debug", platforms: %i[ mri windows ], require: "debug/prelude"
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace is coming from the generator.

…api --skip-tests --skip-keeps --skip-docker --skip-brakeman --no-solid --skip-kamal --skip-thruster
@andyw8 andyw8 force-pushed the andyw8/add-dummy-rails-app branch from 6bc6aef to bc1a95d Compare November 27, 2024 21:53
@andyw8
Copy link
Contributor Author

andyw8 commented Nov 28, 2024

As discussed on Slack, we're going to take a different approach for this.

@andyw8 andyw8 closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant