Introduce RBSSig node
#420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Feb 25, 2025
lib/rbi/model.rb
Outdated
| extend T::Sig | ||
|
|
||
| #: String | ||
| attr_reader :signature |
There was a problem hiding this comment.
Suggested change
| attr_reader :signature | |
| attr_reader :string |
lib/rbi/model.rb
Outdated
| @@ -982,6 +987,21 @@ def ==(other) | |||
| end | |||
| end | |||
|
|
|||
| # RBS signatures | |||
|
|
|||
| class RBSSig < NodeWithComments | |||
There was a problem hiding this comment.
I'm not a fan of the name, what about CommentSig or SigComment?
There was a problem hiding this comment.
I don't think we want to attach comments to them
Suggested change
| class RBSSig < NodeWithComments | |
| class RBSSig < Node |
lib/rbi/printer.rb
Outdated
| #: (RBSSig node) -> void | ||
| def visit_rbs_sig(node) | ||
| print_loc(node) | ||
| printt("#") |
There was a problem hiding this comment.
Let's strip the : when we create the sig so it's nicer to handle, then we add it back when we print:
Suggested change
| printt("#") | |
| printt("#:") |
KaanOzkan
force-pushed
the
ko/rbs-signature
branch
2 times, most recently
from
147feed to
939fdfc
Compare
Morriar
reviewed
Feb 25, 2025
lib/rbi/printer.rb
Outdated
| #: (RBSSig node) -> void | ||
| def visit_rbs_sig(node) | ||
| print_loc(node) | ||
| printt("#:") |
There was a problem hiding this comment.
Suggested change
| printt("#:") | |
| printt("#: ") |
test/rbi/printer_test.rb
Outdated
| @@ -1166,5 +1166,15 @@ def test_print_sigs_with_final | |||
| end | |||
| RBI | |||
| end | |||
|
|
|||
| def test_print_rbs_sigs | |||
| rbs_sig = RBSSig.new(" -> String") | |||
There was a problem hiding this comment.
Suggested change
| rbs_sig = RBSSig.new(" -> String") | |
| rbs_sig = RBSSig.new("-> String") |
KaanOzkan
force-pushed
the
ko/rbs-signature
branch
from
939fdfc to
0f8b48b
Compare
Morriar
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple node that's currently used for printing RBS signatures correctly.