Merge pull request #429 from Shopify/at-extend-t-sig

Remove `extend T::Sig` where possible
Shopify · Mar 6, 2025 · f2f0559 · f2f0559
2 parents d575644 + d580bb7
commit f2f0559
Show file tree

Hide file tree

Showing 33 changed files with 11 additions and 329 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -55,14 +55,14 @@ GEM
     rubocop-sorbet (0.8.9)
       rubocop (>= 1)
     ruby-progressbar (1.13.0)
-    sorbet (0.5.11851)
-      sorbet-static (= 0.5.11851)
-    sorbet-runtime (0.5.11851)
-    sorbet-static (0.5.11851-universal-darwin)
-    sorbet-static (0.5.11851-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11851)
-      sorbet (= 0.5.11851)
-      sorbet-runtime (= 0.5.11851)
+    sorbet (0.5.11899)
+      sorbet-static (= 0.5.11899)
+    sorbet-runtime (0.5.11899)
+    sorbet-static (0.5.11899-universal-darwin)
+    sorbet-static (0.5.11899-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11899)
+      sorbet (= 0.5.11899)
+      sorbet-runtime (= 0.5.11899)
     spoom (1.5.4)
       erubi (>= 1.10.0)
       prism (>= 0.28.0)

diff --git a/lib/rbi.rb b/lib/rbi.rb
@@ -6,9 +6,7 @@
 require "rbs"
 
 module RBI
-  class Error < StandardError
-    extend T::Sig
-  end
+  class Error < StandardError; end
 end
 
 require "rbi/loc"

diff --git a/lib/rbi/formatter.rb b/lib/rbi/formatter.rb
@@ -3,8 +3,6 @@
 
 module RBI
   class Formatter
-    extend T::Sig
-
     #: Integer?
     attr_accessor :max_line_length
 

diff --git a/lib/rbi/index.rb b/lib/rbi/index.rb
@@ -3,12 +3,9 @@
 
 module RBI
   class Index < Visitor
-    extend T::Sig
     include T::Enumerable
 
     class << self
-      extend T::Sig
-
       #: (*Node node) -> Index
       def index(*node)
         index = Index.new
@@ -63,8 +60,6 @@ def index_node(node)
   end
 
   class Tree
-    extend T::Sig
-
     #: -> Index
     def index
       Index.index(self)
@@ -87,7 +82,6 @@ def index_ids; end
   end
 
   class Scope
-    extend T::Sig
     include Indexable
 
     # @override
@@ -98,7 +92,6 @@ def index_ids
   end
 
   class Const
-    extend T::Sig
     include Indexable
 
     # @override
@@ -109,7 +102,6 @@ def index_ids
   end
 
   class Attr
-    extend T::Sig
     include Indexable
 
     # @override
@@ -120,7 +112,6 @@ def index_ids
   end
 
   class Method
-    extend T::Sig
     include Indexable
 
     # @override
@@ -131,7 +122,6 @@ def index_ids
   end
 
   class Include
-    extend T::Sig
     include Indexable
 
     # @override
@@ -142,7 +132,6 @@ def index_ids
   end
 
   class Extend
-    extend T::Sig
     include Indexable
 
     # @override
@@ -153,7 +142,6 @@ def index_ids
   end
 
   class MixesInClassMethods
-    extend T::Sig
     include Indexable
 
     # @override
@@ -164,7 +152,6 @@ def index_ids
   end
 
   class RequiresAncestor
-    extend T::Sig
     include Indexable
 
     # @override
@@ -175,7 +162,6 @@ def index_ids
   end
 
   class Helper
-    extend T::Sig
     include Indexable
 
     # @override
@@ -186,7 +172,6 @@ def index_ids
   end
 
   class TypeMember
-    extend T::Sig
     include Indexable
 
     # @override
@@ -197,7 +182,6 @@ def index_ids
   end
 
   class Send
-    extend T::Sig
     include Indexable
 
     # @override
@@ -208,7 +192,6 @@ def index_ids
   end
 
   class TStructConst
-    extend T::Sig
     include Indexable
 
     # @override
@@ -219,7 +202,6 @@ def index_ids
   end
 
   class TStructProp
-    extend T::Sig
     include Indexable
 
     # @override
@@ -230,7 +212,6 @@ def index_ids
   end
 
   class TEnumBlock
-    extend T::Sig
     include Indexable
 
     # @override

diff --git a/lib/rbi/loc.rb b/lib/rbi/loc.rb
@@ -3,11 +3,7 @@
 
 module RBI
   class Loc
-    extend T::Sig
-
     class << self
-      extend T::Sig
-
       #: (String file, Prism::Location prism_location) -> Loc
       def from_prism(file, prism_location)
         new(