-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Card] Add full example to styleguide #939
Conversation
c40d08a
to
1652e4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, but it combines some props that aren’t intended to be combined. Also, DataTable doesn’t look great in this context; consider some other content for the sections.
1652e4f
to
ad7aa3f
Compare
5c5eb88
to
4f87078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things, otherwise looking good 😃
4f87078
to
e882a6c
Compare
e882a6c
to
88c4aa6
Compare
88c4aa6
to
6172f94
Compare
6172f94
to
a337417
Compare
a337417
to
cf57429
Compare
c271b8d
to
a0c98c0
Compare
91703b3
to
637611e
Compare
637611e
to
9899e89
Compare
9899e89
to
8974a9f
Compare
8974a9f
to
3c2e83c
Compare
WHY are these changes introduced?
Resolves #890
WHAT is this pull request doing?
Adds an example to the
styleguide
that includes a combination of all the props available forCard
.Copy-paste this code in
playground/Playground.tsx
:🎩 checklist