Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook] Direct example description links to https://polaris.shopify.com #933

Merged
merged 2 commits into from
Feb 7, 2019
Merged

[Storybook] Direct example description links to https://polaris.shopify.com #933

merged 2 commits into from
Feb 7, 2019

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Jan 25, 2019 •
edited
Loading

WHY are these changes introduced?

  1. Go to https://polaris-react.herokuapp.com/?selectedKind=All%20Components%7CApp%20provider&selectedStory=With%20theme&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fnotes%2Fpanel
  2. In the "notes" panel, click "top bar"

Expected

https://polaris.shopify.com/components/structure/top-bar loads

Actual

https://polaris-react.herokuapp.com/components/structure/top-bar loads

WHAT is this pull request doing?

Adds https://polaris.shopify.com at the beginning of links so they open the style guide correctly.

🥇 Mad props to @BPScott for teaching me how the webpack Markdown loader works and pairing with me on coding this

How to 🎩

  1. Go to https://polaris-react-pr-933.herokuapp.com/?selectedKind=All%20Components%7CApp%20provider&selectedStory=With%20theme&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fnotes%2Fpanel
  2. In the "notes" panel, click "top bar"

It should point to https://polaris.shopify.com/components/structure/top-bar

@kaelig kaelig requested a review from BPScott January 25, 2019 01:02
@BPScott BPScott temporarily deployed to polaris-react-pr-933 January 25, 2019 01:03 Inactive
@kaelig kaelig mentioned this pull request Jan 25, 2019
Closed
6 tasks
@kaelig kaelig temporarily deployed to polaris-react-pr-933 January 25, 2019 19:51 Inactive
@kaelig kaelig temporarily deployed to polaris-react-pr-933 February 7, 2019 00:29 Inactive
@BPScott
Copy link
Member

BPScott commented Feb 7, 2019

Can you rebase rather than merge as it makes the PR super hard to read?

@kaelig
Copy link
Contributor Author

kaelig commented Feb 7, 2019 •
edited
Loading

Oops, this is not what I expected… lemme redo that.

Edit: repushed!

@kaelig kaelig force-pushed the link-to-styleguide branch from 787da80 to 270cf45 Compare February 7, 2019 00:37
@kaelig
Copy link
Contributor Author

kaelig commented Feb 7, 2019

I also added some tophatting instructions, hope it helps.

BPScott
BPScott approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Sorry it took forever to get around to reviewing this.

@kaelig
Copy link
Contributor Author

kaelig commented Feb 7, 2019

Thanks! It’s on me… Sorry for the lack of easy tophatting instructions in the initial PR…

@kaelig kaelig merged commit a8640fa into master Feb 7, 2019
@kaelig kaelig deleted the link-to-styleguide branch February 7, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BPScott BPScott BPScott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaelig @BPScott