Data table and resource list a11y docs #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpersing
commented
Jan 23, 2019
chloerice
approved these changes
Jan 23, 2019
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
|
Thank you for your notes, @chloerice ! I've added your changes. 😃 |
kaelig
suggested changes
Jan 24, 2019
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
|
Updated with |
kaelig
reviewed
Jan 25, 2019
kaelig
suggested changes
Jan 25, 2019
| ### Keyboard support | ||
|
|
||
| Sorting controls for the data table component are implemented with native HTML buttons. | ||
|
|
There was a problem hiding this comment.
Note on the list below: it describes behaviors that should come for free when using native HTML buttons (as recommended above). Wondering if this is still worth mentioning?
There was a problem hiding this comment.
I'd like to include this because folks don't always know what keyboard inputs are native.
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds component-level accessibility documentation to the data table and resource list components (which link to each other), to display in the
polaris-reactrepo and on the style guide. Changes should appear at the bottom of the gray Examples and Props section.WHY are these changes introduced?
Adds documentation on accessibility features built into the components.
WHAT is this pull request doing?
README.mdfiles for the data table and resource list components to add a new section.UNRELEASED.md.How to 🎩
polaris-styleguideto get the changes that support the accessibility section.polaris-reactand run the instructions for testing in a consuming project.polaris-styleguidetab, rundev up && dev start.Screenshot example