Revert "Move from local icons to polaris-icons (#686)"

[AndrewMusgrave]

This reverts commit d847fc6.

WHY are these changes introduced?

Polaris icon's cannot be resolved

WHAT is this pull request doing?

Reverting #686

How to 🎩

Build consumer to web or polaris styleguide

[AndrewMusgrave]

cc/ @amrocha @kaelig

[kaelig]

Please don't revert. The error is due to a limitation in build-consumer, which doesn't install transitive dependencies.

[AndrewMusgrave]

Please don't revert. The error is due to a limitation in build-consumer, which doesn't install transitive dependencies.

I'm not familiar with the term transitive dependencies, what are they?

Is this something that can easily be fixed forward? @kaelig

[BPScott]

Transitive dependencies are dependencies of dependencies. In this case polaris-styleguide does not directly depend upon polaris-icons, but on polaris-react, which in turn depends upon polaris-icons.

polaris-icons is a new dependency of polaris-react that only exists on master.

Running yarn build consumer polaris-styleguide does not install any of polaris-react's dependencies into polaris-styleguide. Most of the time this works by fluke as we don't change dependencies that often (and styleguide will use dependencies of what it has in its package.json). However in this case polaris-styleguide can't find the polaris-icons package because it has not been installed - it isn't there in polaris 3.3.0.

This will fix itself once we release a new version of polaris-react and update polaris-styleguide to use that version.

[AndrewMusgrave]

Running yarn build consumer polaris-styleguide does not install any of polaris-react's dependencies into polaris-styleguide. Most of the time this works by fluke as we don't change dependencies that often (and styleguide will use dependencies of what it has in its package.json). However in this case polaris-styleguide can't find the polaris-icons package because it has not been installed - it isn't there in polaris 3.3.0. This will fix itself once we release a new version of polaris-react and update polaris-styleguide to use that version.

Thanks, TIL. That's unfortunate, build-consumer may need to be improved since it's heavily used for testing on web, where we should be checking our changes and builds before release. If this is fixed with a release, is there a reason why we haven't done one already?

[dleroux]

But technically we should't release a new version of Polaris unless we are able to build-consumer and properly tophat our release?