Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contextual VideoCard and VideoThumbnail components #2725
Add Contextual VideoCard and VideoThumbnail components #2725
Changes from 16 commits
19fe3fb
b10840e
d03e112
b47b918
0502b58
76711ed
ecc2f36
dd21771
2e82610
4290046
a95240d
f357812
5d14d5d
da10f38
60e0c4a
c8697e8
03920b3
dfe5905
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.plural.andSeconds
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.plural.andSecond
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.plural.andSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.plural.andSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.only
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.only
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinutes
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinutes
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinute
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinutes
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinute
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinute
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinutes
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andMinute
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minutesAndSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.minuteAndSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.hours.singular.andSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.only
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.only
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.andSeconds
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.andSeconds
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.andSecond
contains the wordplural
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.andSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.plural.andSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.singular.only
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source string detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.singular.andSeconds
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Questions about these messages? Hop in the #intl-tools-and-services Slack channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poorly localized source strings detected
List of problems detected:
Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.singular.andSecond
contains the wordsingular
. Please make use of the pluralization subkeysone
andother
instead (see String Externalization Guide).Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.singular.andSeconds
,Polaris.VideoThumbnail.playButtonA11yLabel.duration.minutes.singular.andSecond
seem to be pluralization variations of one another. Please take a look at https://development.shopify.io/engineering/developing_at_Shopify/internationalization/string_externalization#_Pluralization to see if they should be replaced withone
andother
keys.Questions about these messages? Hop in the #intl-tools-and-services Slack channel.