Use export * in utility indexes too #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
export-star-utilities
branch
from
aafb3dd to
a290073
Compare
amrocha
approved these changes
Jan 21, 2020
| @@ -2,9 +2,7 @@ import {isServer} from '../target'; | |||
|
|
|||
| export const SCROLL_LOCKING_ATTRIBUTE = 'data-lock-scrolling'; | |||
|
|
|||
| export const SCROLL_LOCKING_WRAPPER_ATTRIBUTE = 'data-lock-scrolling-wrapper'; | |||
|
|
|||
| export const SCROLL_LOCKING_CUSTOM_PROPERTY = '--scroll-lock-body-padding'; | |||
There was a problem hiding this comment.
are you sure we can remove this?
There was a problem hiding this comment.
I checked for usages and there were none outside the current file, I then removed the export and it complained that it was never used inside this file either
|
|
||
| export {Theme, ThemeConfig, CustomPropertiesLike, ColorScheme} from './types'; | ||
| export {ThemeConfig} from './types'; |
There was a problem hiding this comment.
There's a bunch of other types in that file that are used within this folder, but not externally. As most of this is going to be extracted into polaris-tokens pretty soon it didn't seem worth the refactoring to split this into a types and private-types file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Following on from #2619 and #2625 I looked at the utility index files and spotted that in almost all cases our index files rexport everything in the files they reference, or what they references is never used externally, so they can also use
export *too.WHAT is this pull request doing?
export *because doing things one way everywhere is easier than doing things one way incomponentsand another way inutilitiesI did run into some issues with some interfaces that get used as the type that gets pushed into a React context.
I could either have those as a type or export the interface. I figured exporting the interface was an acceptable compromise as "a slightly leaky internal export that doesn't bleed into our public exports" was better than "disabling our linting rule that prefers the usage of interfaces over types".
How to 🎩
Type check and tests pass