Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card] Custom footer actions example should be right aligned #2603

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

LauraAubin
Copy link
Contributor

WHY are these changes introduced?

Card footer actions are now right aligned by default, but the custom footer example was left aligned.

WHAT is this pull request doing?

Wrap the ButtonGroup in a Stack.

@LauraAubin LauraAubin changed the title Card custom footer example should be right aligned [Card] Custom with custom footer actions example should be right aligned Jan 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2020

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@LauraAubin LauraAubin force-pushed the card-custom-footer-alignment branch from 4aca785 to bb26bcb Compare January 7, 2020 22:24
@LauraAubin LauraAubin requested review from dleroux and mateus January 7, 2020 22:32
Copy link
Member

@mateus mateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@LauraAubin LauraAubin changed the title [Card] Custom with custom footer actions example should be right aligned [Card] Custom footer actions example should be right aligned Jan 7, 2020
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laura! Left a minor suggestion on the release note.

@LauraAubin LauraAubin merged commit 48c28a7 into master Jan 8, 2020
@LauraAubin LauraAubin deleted the card-custom-footer-alignment branch January 8, 2020 19:47
kyledurand pushed a commit that referenced this pull request Jan 14, 2020
* Card custom footer example should be right aligned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants