[Color system] opacity (Card, Popover, Modal, Navigation) #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrosenthal
added
the
🤖Skip Changelog
danrosenthal
changed the title
tmlayton
reviewed
Oct 29, 2019
src/utilities/theme/utils.ts
Outdated
| lightness: 0, | ||
| alpha: 0.15, | ||
| }, | ||
| opacityDeep: { |
There was a problem hiding this comment.
Suggested change
| opacityDeep: { | |
| backdrop: { |
tmlayton
reviewed
Oct 29, 2019
src/utilities/theme/utils.ts
Outdated
| @@ -258,6 +259,29 @@ function successColors(color: HSLAColor, lightSurface: boolean) { | |||
| }; | |||
| } | |||
|
|
|||
| function opacityColors() { | |||
There was a problem hiding this comment.
Pedantic as this is function name is private, but:
Suggested change
| function opacityColors() { | |
| function translucentColors() { |
tmlayton
reviewed
Oct 29, 2019
src/utilities/theme/utils.ts
Outdated
| @@ -258,6 +259,29 @@ function successColors(color: HSLAColor, lightSurface: boolean) { | |||
| }; | |||
| } | |||
|
|
|||
| function opacityColors() { | |||
| return { | |||
| opacityShallow: { | |||
There was a problem hiding this comment.
Suggested change
| opacityShallow: { | |
| diffuseShadow: { |
There was a problem hiding this comment.
Though I found myself explaining this as:
Suggested change
| opacityShallow: { | |
| shadowFromAmbientLight: { |
tmlayton
reviewed
Oct 29, 2019
src/utilities/theme/utils.ts
Outdated
| lightness: 8, | ||
| alpha: 0.05, | ||
| }, | ||
| opacity: { |
There was a problem hiding this comment.
Suggested change
| opacity: { | |
| concentratedShadow: { |
There was a problem hiding this comment.
And like this:
Suggested change
| opacity: { | |
| shadowFromDirectLight: { |
tmlayton
force-pushed
the
color-system/opacity
branch
from
7a3a2df to
1481518
Compare
tmlayton
force-pushed
the
color-system/hsluv
branch
from
1f4cd23 to
eaa9b45
Compare
|
Going to merge this into #2361 so we can test changes on that branch. |
tmlayton
pushed a commit
that referenced
this pull request
Nov 5, 2019
tmlayton
pushed a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.