[Filters] Add onQueryFocused callback #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajay
force-pushed
the
add-query-focus-callback-to-filters
branch
from
beb1936 to
6991354
Compare
joshuajay
requested review from
tmlayton and
AndrewMusgrave
and removed request for
AndrewMusgrave
tmlayton
suggested changes
Aug 12, 2019
joshuajay
force-pushed
the
add-query-focus-callback-to-filters
branch
from
6991354 to
e332afc
Compare
|
@tmlayton Thanks Tim! Test has been added. |
tmlayton
approved these changes
Aug 12, 2019
amrocha
approved these changes
Aug 12, 2019
|
Will setup a new shipit stack to cut 3.21.1 with this change |
tmlayton
pushed a commit
that referenced
this pull request
Aug 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Current functionality in web relies on an
onQueryFocuscallback on the ListFilters component in polaris-next. This is used to instrument the search behaviour, where a focus event on the query field indicates the beginning of the users intent to search.Tim's excellent PR to replace the polaris-next ListFilters with the proper Filter component from Polaris means we can no longer do this. (see https://github.com/Shopify/web/pull/15425#discussion_r311870970)
WHAT is this pull request doing?
Adding a callback to the Filters component to be triggered when the query field is focused.
🎩 checklist
README.mdwith documentation changes