[ActionMenu] Move margin-top to Page > Header.scss #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beefchimi
added
the
Bug
beefchimi
commented
Jun 21, 2019
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import classNames from 'classnames'; | |||
| import {classNames} from '@shopify/css-utilities'; | |||
There was a problem hiding this comment.
Consistent import for classNames
chloerice
approved these changes
Jun 22, 2019
danrosenthal
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building out some UI in my app, I realized that I stuck
margin-topon theActionMenuwhen in reality it should be up to the consuming parent how to provide spacing.All I have done is simply move
margin-topfromActionMenu.scssintoHeader.scss. The visual result within Polaris is exactly the same.I'm keeping the negative
margin-leftas that is specifically for offsetting the action padding - so that spacing logic makes sense withinActionMenu.Below is a gif of my app. This is with the current ActionMenu (with
margin-top). You can see me toggling themargin-topon/off. Once this PR merges, I won't have to worry about this spacing discrepancy.Also, I have applied the
skip changeloglabel, as there is no change for the end user, and the ActionMenu has not been released yet.