Fix issue where tsx would copy the package.json file where it shouldn't #1466
Conversation
amrocha
added
Bug
This file is never imported by any files and its inclusion in the esnext folder results in npm's files directive not being processed correctly (i.e. a bunch of files are left out)
|
I've worked out where that package.json was coming from and have stopped it from making its way into build-intermediate in the first place. It was listed as an explicit include in our tsconfig.json and I guess TS 3.2 now explicitly adds everything listed in your includes to your built output folder, even if you never reference a particular file. Since the PR that added that in the first place we've changed our approach to how we inject version numbers into the project. Nothing ever imports package.json so it's fine to remove it from the includes array, which in turn stops it appearing in the build-intermediate and esnext folders. |
There was a problem hiding this comment.
Build looks good: https://unpkg.com/@shopify/polaris@3.14.1-rc.3/esnext/
Nice fix! 🙏
|
That would do it, good job figuring this out everyone! |
WHY are these changes introduced?
We can't update
polaris-reactinwebbecause of this bug.This issue was introduced when we updated Typescript from 3.1.6 to 3.2.4.
WHAT is this pull request doing?
In 3.2.4,
tscincludes the root directory'spackage.jsonfile in the output build by defaultThis is a problem because the "files" key in the root
package.jsonends up filtering which files get included in the build output. Ideally the package.json file wouldn't be copied, but I couldn't easily figure out how to configure that, so I delete thepackage.jsonfile before copying thetscoutput to its proper folder.How to 🎩
Run a build, and run the following command:
And then inspect
packoutput.txt. Check that the files included in the/esnext/folder look like this: https://unpkg.com/@shopify/polaris@3.13.0/esnext/