Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context #1459

Closed
wants to merge 12 commits into from
Closed

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented May 10, 2019

WHY are these changes introduced?

Updating some context conversions described in #1403.

  • export the result of React.createContext rather than provider/consumer
  • use {Component}/context.tsx rather than {Component}/Components/Context/Context.tsx
  • create the context type in the context file rather than a shared types file
  • describe the context object in the render method to be more in line with function style components

WHAT is this pull request doing?

As described above for all contexts excluding withRef, which will be removed in v4.

Notes

  • Kept my combines separate for now in case it makes 🎩 / review easier

@BPScott BPScott temporarily deployed to polaris-react-pr-1459 May 10, 2019 22:37 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1459 May 13, 2019 14:46 Inactive
@AndrewMusgrave AndrewMusgrave changed the title [WIP] Update context Update context May 13, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1462 May 13, 2019 15:22 Inactive
@AndrewMusgrave AndrewMusgrave deleted the new-context-style branch September 30, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants