Skip to content

Commit

Permalink
Rewrote tests to follow Polaris test style
Browse files Browse the repository at this point in the history
Fix broken references in readme loader

Move translations to the locale file

Fix failing i18n pluralization

Accessibility labbel for popover activator

Minor update to UNRELEASED.md

Minor test update
  • Loading branch information
mSitkovets authored and Yuriy Savenko committed Feb 9, 2020
1 parent d8da2f1 commit fb42862
Show file tree
Hide file tree
Showing 14 changed files with 527 additions and 144 deletions.
4 changes: 3 additions & 1 deletion .storybook/polaris-readme-loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ import {
TrapFocus,
Truncate,
UnstyledLink,
VisuallyHidden
VisuallyHidden,
VideoCard,
VideoThumbnail
} from '@shopify/polaris';
import {
PlusMinor,
Expand Down
4 changes: 4 additions & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

### Breaking changes

### New components

- Added new components `VideoCard` and `VideoThumbnail` ([#2725](https://github.com/Shopify/polaris-react/pull/2725))

### Enhancements

- Added high contrast outline to `ActionList` ([#2713](https://github.com/Shopify/polaris-react/pull/2713))
Expand Down
42 changes: 10 additions & 32 deletions locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@
"label": "Avatar",
"labelWithInitials": "Avatar with initials {initials}"
},

"Autocomplete": {
"spinnerAccessibilityLabel": "Loading"
},

"Badge": {
"PROGRESS_LABELS": {
"incomplete": "Incomplete",
Expand All @@ -23,12 +21,10 @@
"new": "New"
}
},

"Button": {
"spinnerAccessibilityLabel": "Loading",
"connectedDisclosureAccessibilityLabel": "Related actions"
},

"Common": {
"checkbox": "checkbox",
"undo": "Undo",
Expand All @@ -39,19 +35,16 @@
"submit": "Submit",
"more": "More"
},

"ContextualSaveBar": {
"save": "Save",
"discard": "Discard"
},

"DataTable": {
"sortAccessibilityLabel": "sort {direction} by",
"navAccessibilityLabel": "Scroll table {direction} one column",
"totalsRowHeading": "Totals",
"totalRowHeading": "Total"
},

"DatePicker": {
"previousMonth": "Show previous month, {previousMonthName} {showPreviousYear}",
"nextMonth": "Show next month, {nextMonth} {nextYear}",
Expand Down Expand Up @@ -80,20 +73,17 @@
"sunday": "Su"
}
},

"DiscardConfirmationModal": {
"title": "Discard all unsaved changes",
"message": "If you discard changes, you’ll delete any edits you made since you last saved.",
"primaryAction": "Discard changes",
"secondaryAction": "Continue editing"
},

"DropZone": {
"overlayTextFile": "Drop file to upload",
"overlayTextImage": "Drop image to upload",
"errorOverlayTextFile": "File type is not valid",
"errorOverlayTextImage": "Image type is not valid",

"FileUpload": {
"actionTitleFile": "Add file",
"actionTitleImage": "Add image",
Expand All @@ -102,28 +92,23 @@
"label": "Upload file"
}
},

"EmptySearchResult": {
"altText": "Empty search results"
},

"Frame": {
"skipToContent": "Skip to content",
"Navigation": {
"closeMobileNavigationLabel": "Close navigation"
}
},

"Icon": {
"backdropWarning": "The {color} icon doesn’t accept backdrops. The icon colors that have backdrops are: {colorsWithBackDrops}"
},

"ActionMenu": {
"RollupActions": {
"rollupButton": "Actions"
}
},

"Filters": {
"moreFilters": "More filters",
"moreFiltersWithCount": "More filters ({count})",
Expand All @@ -135,23 +120,19 @@
"clear": "Clear",
"clearLabel": "Clear {filterName}"
},

"Modal": {
"iFrameTitle": "body markup",
"modalWarning": "These required properties are missing from Modal: {missingProps}"
},

"Pagination": {
"previous": "Previous",
"next": "Next",
"pagination": "Pagination"
},

"ProgressBar": {
"negativeWarningMessage": "Values passed to the progress prop shouldn’t be negative. Resetting {progress} to 0.",
"exceedWarningMessage": "Values passed to the progress prop shouldn’t exceed 100. Setting {progress} to 100."
},

"ResourceList": {
"sortingLabel": "Sort by",
"defaultItemSingular": "item",
Expand All @@ -171,34 +152,28 @@
"a11yCheckboxSelectAllMultiple": "Select all {itemsLength} {resourceNamePlural}",
"ariaLiveSingular": "{itemsLength} item",
"ariaLivePlural": "{itemsLength} items",

"Item": {
"actionsDropdownLabel": "Actions for {accessibilityLabel}",
"actionsDropdown": "Actions dropdown",
"viewItem": "View details for {itemName}"
},

"BulkActions": {
"actionsActivatorLabel": "Actions",
"moreActionsActivatorLabel": "More actions",
"warningMessage": "To provide a better user experience. There should only be a maximum of {maxPromotedActions} promoted actions."
},

"FilterCreator": {
"filterButtonLabel": "Filter",
"selectFilterKeyPlaceholder": "Select a filter\u2026",
"addFilterButtonLabel": "Add filter",
"showAllWhere": "Show all {resourceNamePlural} where:"
},

"FilterControl": {
"textFieldLabel": "Search {resourceNamePlural}"
},

"FilterValueSelector": {
"selectFilterValuePlaceholder": "Select a filter\u2026"
},

"DateSelector": {
"dateFilterLabel": "Select a value",
"dateValueLabel": "Date",
Expand Down Expand Up @@ -230,35 +205,38 @@
}
}
},

"SkeletonPage": {
"loadingLabel": "Page loading"
},

"Spinner": {
"warningMessage": "The color {color} is not meant to be used on {size} spinners. The colors available on large spinners are: {colors}"
},

"Tabs": {
"toggleTabsLabel": "More tabs"
},

"Tag": {
"ariaLabel": "Remove {children}"
},

"TextField": {
"characterCount": "{count} characters",
"characterCountWithMaxLength": "{count} of {limit} characters used"
},

"TopBar": {
"toggleMenuLabel": "Toggle menu",

"SearchField": {
"clearButtonLabel": "Clear",
"search": "Search"
}
},
"VideoCard": {
"popoverButton": "Actions"
},
"VideoThumbnail": {
"playButtonDefault": "Play video",
"playButtonWithTime": "Play video of length ",
"hoursLabel": "{hours} hours",
"minutesLabel": "{minutes} minutes",
"secondsLabel": "{seconds} seconds"
}
}
}
Loading

0 comments on commit fb42862

Please sign in to comment.