Merge pull request #1243 from Shopify/fix-cancel-text

[ResourceList] - Adding bulk action cancel button translation
Shopify · Mar 26, 2019 · f82a661 · f82a661
2 parents f5a8e04 + 839e900
commit f82a661
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -18,6 +18,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 
 - Fixed disabled states while loading for `ResourceList` ([#1237](https://github.com/Shopify/polaris-react/pull/1237))
 - Fixed `Checkbox` from losing focus and not receiving some modified events([#1112](https://github.com/Shopify/polaris-react/pull/1112))
+- Added translation for the cancel button on the `ResourceList` `BulkActions` ([#1243](https://github.com/Shopify/polaris-react/pull/1243))
 
 ### Documentation
 

diff --git a/src/components/ResourceList/components/BulkActions/BulkActions.tsx b/src/components/ResourceList/components/BulkActions/BulkActions.tsx
@@ -249,7 +249,7 @@ export class BulkActions extends React.PureComponent<CombinedProps, State> {
         testID="btn-cancel"
         disabled={disabled}
       >
-        Cancel
+        {intl.translate('Polaris.Common.cancel')}
       </button>
     );
 

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -30,7 +30,8 @@
 
     "Common": {
       "checkbox": "checkbox",
-      "undo": "Undo"
+      "undo": "Undo",
+      "cancel": "Cancel"
     },
 
     "ContextualSaveBar": {