Remove redundant null check

This check is redundant, since it should already be covered by else { return autoComplete; }
Shopify · Feb 27, 2020 · ec0b0f9 · ec0b0f9
1 parent 6be34a1
commit ec0b0f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -21,4 +21,6 @@
 
 ### Code quality
 
+- Removed redundant null check in `TextField` ([#2783](https://github.com/Shopify/polaris-react/pull/2783))
+
 ### Deprecations
diff --git a/src/components/TextField/TextField.tsx b/src/components/TextField/TextField.tsx
@@ -490,9 +490,7 @@ export function TextField({
 }
 
 function normalizeAutoComplete(autoComplete?: boolean | string) {
-  if (autoComplete == null) {
-    return autoComplete;
-  } else if (autoComplete === true) {
+  if (autoComplete === true) {
     return 'on';
   } else if (autoComplete === false) {
     return 'off';
Original file line number	Diff line number	Diff line change
Expand Up		@@ -21,4 +21,6 @@

		### Code quality

		- Removed redundant null check in `TextField` ([#2783](https://github.com/Shopify/polaris-react/pull/2783))

		### Deprecations