Skip to content

Commit

Permalink
Fix frame embedded app context errors (#613)
Browse files Browse the repository at this point in the history
* Fix frame embedded app context errors

* add changelog entry
  • Loading branch information
AndrewMusgrave authored and tmlayton committed Nov 13, 2018
1 parent fe2b6d1 commit e7250cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
- Removed erroneous scss file import that rendered Polaris unable to be used in typescript projects without scss support ([#609](https://github.com/Shopify/polaris-react/pull/609))
- Fixed `Popover` inconsistent `border-radius` values ([#605](https://github.com/Shopify/polaris-react/pull/605))
- `TextStyle` "strong" variant now uses a `span` tag instead of `b` ([#606](https://github.com/Shopify/polaris-react/pull/606))
- Fixed non-blocking context errors when using `Toast` or `Loading` in an embedded app ([#613](https://github.com/Shopify/polaris-react/pull/613))

### Documentation

Expand Down
2 changes: 1 addition & 1 deletion src/components/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface FrameContext {
}

export const frameContextTypes = {
frame: PropTypes.object.isRequired,
frame: PropTypes.object,
};

export type TransitionStatus = 'entering' | 'entered' | 'exiting' | 'exited';

0 comments on commit e7250cc

Please sign in to comment.