Skip to content

Commit

Permalink
Add test, change release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Page authored and chloerice committed Oct 11, 2019
1 parent 50f8229 commit b776dfc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Bug fixes

- Fixes PositionOverlay incorrectly calculating the left value for right aligned components with scroll bars ([#1692](https://github.com/Shopify/polaris-react/pull/1692))
- Fixes TopBar Menu from incorrectly calculating the width ([#1692](https://github.com/Shopify/polaris-react/pull/1692))

### Documentation

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('<PositionedOverlay />', () => {
});

describe('preferredAlignment', () => {
it('aligns left if preferredAlignment is given', () => {
it('aligns left if preferredAlignment left is given', () => {
const positionedOverlay = mountWithAppProvider(
<PositionedOverlay {...mockProps} preferredAlignment="left" />,
);
Expand All @@ -73,6 +73,16 @@ describe('<PositionedOverlay />', () => {
(positionedOverlay.find('div').prop('style') as any).left,
).toBeUndefined();
});

it('aligns right if preferredAlignment right is given', () => {
const positionedOverlay = mountWithAppProvider(
<PositionedOverlay {...mockProps} preferredAlignment="right" />,
);

expect(
(positionedOverlay.find('div').prop('style') as any).right,
).toBeUndefined();
});
});

describe('fullWidth', () => {
Expand Down

0 comments on commit b776dfc

Please sign in to comment.