Merge pull request #2428 from Shopify/message-indicator-color-system

[ColorSystem][MessageIndicator] Improve contrast and use color system
Shopify · Nov 26, 2019 · b0085a7 · b0085a7
2 parents bf52cc8 + 82f73c1
commit b0085a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -10,6 +10,7 @@
 - Fixed an accessibility issue where the `Form` implicit submit was still accessible via keyboard ([#2447](https://github.com/Shopify/polaris-react/pull/2447))
 - Moved `Button` styles from the `Buttongroup` CSS file to the `Button` CSS file ([#2441](https://github.com/Shopify/polaris-react/pull/2441))
 - Added `footerActionAlignment` prop to control `<Card>` footer action alignment, defaults to `'right'`
+- Improved contrast of `MessageIndicator` with a border ([#2428](https://github.com/Shopify/polaris-react/pull/2428))
 
 ### Bug fixes
 

diff --git a/src/components/MessageIndicator/MessageIndicator.scss b/src/components/MessageIndicator/MessageIndicator.scss
@@ -1,6 +1,7 @@
 @import '../../styles/common';
 
-$indicator-size: rem(8px);
+$indicator-size: rem(12px);
+$indicator-position: rem(-3px);
 
 .MessageIndicatorWrapper {
   position: relative;
@@ -9,10 +10,11 @@ $indicator-size: rem(8px);
 .MessageIndicator {
   position: absolute;
   z-index: 1;
-  top: 0;
-  right: 0;
+  top: $indicator-position;
+  right: $indicator-position;
   width: $indicator-size;
   height: $indicator-size;
   border-radius: 100%;
-  background-color: color('teal');
+  background-color: var(--p-highlight-icon, color('teal'));
+  border: solid rem(2px) var(--p-surface-background, var(--top-bar-background));
 }