Fix hardcoded content warnings

Shopify · May 3, 2019 · ac429bc · ac429bc
1 parent 76f9bb7
commit ac429bc
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 2 deletions.
diff --git a/src/components/ProgressBar/ProgressBar.tsx b/src/components/ProgressBar/ProgressBar.tsx
@@ -42,6 +42,7 @@ function ProgressBar({
     <div className={className}>
       <progress className={styles.Progress} value={parsedProgress} max="100" />
       <div className={styles.Indicator} style={{width: `${parsedProgress}%`}}>
+        {/* eslint-disable-next-line shopify/jsx-no-hardcoded-content */}
         <span className={styles.Label}>{parsedProgress}%</span>
       </div>
     </div>

diff --git a/src/components/SkeletonPage/SkeletonPage.tsx b/src/components/SkeletonPage/SkeletonPage.tsx
@@ -36,6 +36,7 @@ export class SkeletonPage extends React.PureComponent<CombinedProps, never> {
       secondaryActions,
       title = '',
       breadcrumbs,
+      polaris: {intl},
     } = this.props;
 
     const className = classNames(
@@ -80,7 +81,11 @@ export class SkeletonPage extends React.PureComponent<CombinedProps, never> {
     ) : null;
 
     return (
-      <div className={className} role="status" aria-label="Page loading">
+      <div
+        className={className}
+        role="status"
+        aria-label={intl.translate('Polaris.SkeletonPage.loadingLabel')}
+      >
         {headerMarkup}
         <div className={styles.Content}>{children}</div>
       </div>

diff --git a/src/components/TopBar/TopBar.tsx b/src/components/TopBar/TopBar.tsx
@@ -59,6 +59,7 @@ export class TopBar extends React.PureComponent<ComposedProps, State> {
       onSearchResultsDismiss,
       contextControl,
       polaris: {
+        intl,
         theme: {logo},
       },
     } = this.props;
@@ -77,7 +78,7 @@ export class TopBar extends React.PureComponent<ComposedProps, State> {
         onClick={onNavigationToggle}
         onFocus={this.handleFocus}
         onBlur={this.handleBlur}
-        aria-label="Toggle menu"
+        aria-label={intl.translate('Polaris.TopBar.toggleMenuLabel')}
       >
         <Icon source={MobileHamburgerMajorMonotone} color="white" />
       </button>

diff --git a/src/locales/en.json b/src/locales/en.json
@@ -211,6 +211,10 @@
       }
     },
 
+    "SkeletonPage": {
+      "loadingLabel": "Page loading"
+    },
+
     "Spinner": {
       "warningMessage": "The color {color} is not meant to be used on {size} spinners. The colors available on large spinners are: {colors}"
     },
@@ -222,6 +226,14 @@
     "TextField": {
       "characterCount": "{count} characters",
       "characterCountWithMaxLength": "{count} of {limit} characters used"
+    },
+
+    "TopBar": {
+      "toggleMenuLabel": "Toggle menu",
+
+      "SearchField": {
+        "clearButtonLabel": "Clear"
+      }
     }
   }
 }