Skip to content

Commit

Permalink
Flip the order of some values in a calc (#2643)
Browse files Browse the repository at this point in the history
This fixes build crashes in CRA thanks to a parser bug that explodes
when it encounters the original order (but inverted is fine)
  • Loading branch information
BPScott authored Jan 22, 2020
1 parent 5740b6b commit a3fcf46
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Bug fixes

- Fixed scrolling with scrollbar not working in Popover when content changes on scroll ([#2627](https://github.com/Shopify/polaris-react/pull/2627))
- Work around a build crash when using create-react-app due to a bug in css parsing in `postcss-custom-properties` ([#2643](https://github.com/Shopify/polaris-react/pull/2643))

### Documentation

Expand Down
8 changes: 4 additions & 4 deletions src/styles/shared/_controls.scss
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@
&::before {
content: '';
position: absolute;
top: calc(var(--control-border-width) * -1);
right: calc(var(--control-border-width) * -1);
bottom: calc(var(--control-border-width) * -1);
left: calc(var(--control-border-width) * -1);
top: calc(-1 * var(--control-border-width));
right: calc(-1 * var(--control-border-width));
bottom: calc(-1 * var(--control-border-width));
left: calc(-1 * var(--control-border-width));
border-radius: var(--p-border-radius-base);
background-color: var(--p-action-interactive);
opacity: 0;
Expand Down

0 comments on commit a3fcf46

Please sign in to comment.