Only recolor external link icon in Link

Shopify · Jun 26, 2019 · 58c8a8a · 58c8a8a
1 parent b0ce369
commit 58c8a8a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -28,8 +28,9 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 
 ### Bug fixes
 
-- Fixes `monochrome` variant of `Link` and `Button` components to support multi-line link text ([#1686](https://github.com/Shopify/polaris-react/pull/1686))
+- Fixed `monochrome` variant of `Link` and `Button` components to support multi-line link text ([#1686](https://github.com/Shopify/polaris-react/pull/1686))
 - Fixed the first column of `DataTable` not rendering in iOS Safari (([#1605](https://github.com/Shopify/polaris-react/pull/1605))
+- Fixed a regression introduced in #1247, where icons inside of `Link` would always be recolored to match the text color ([#1729](https://github.com/Shopify/polaris-react/pull/1729))
 
 ### Documentation
 

diff --git a/src/components/Link/Link.scss b/src/components/Link/Link.scss
@@ -1,5 +1,4 @@
 .Link {
-  @include recolor-icon(currentColor);
   appearance: none;
   display: inline;
   text-align: inherit;
@@ -18,6 +17,7 @@
 }
 
 .IconLockup {
+  @include recolor-icon(currentColor);
   display: inline;
   white-space: nowrap;