[MessageIndicator] Convert to use color system, improve contrast

Shopify · Nov 14, 2019 · 38874a7 · 38874a7
1 parent 03c9b88
commit 38874a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -4,6 +4,8 @@
 
 ### Enhancements
 
+- Improved contrast of `MessageIndicator` with a border and converted from `color` Sass mixin to CSS variables ([#2428](https://github.com/Shopify/polaris-react/pull/2428))
+
 ### Bug fixes
 
 - Fixed an issue where the dropzone component jumped from an extra-large layout to a layout based on the width of it's container ([#2412](https://github.com/Shopify/polaris-react/pull/2412))

diff --git a/src/components/MessageIndicator/MessageIndicator.scss b/src/components/MessageIndicator/MessageIndicator.scss
@@ -1,6 +1,7 @@
 @import '../../styles/common';
 
-$indicator-size: rem(8px);
+$indicator-size: 1.2rem;
+$indicator-position: rem(-3px);
 
 .MessageIndicatorWrapper {
   position: relative;
@@ -9,10 +10,11 @@ $indicator-size: rem(8px);
 .MessageIndicator {
   position: absolute;
   z-index: 1;
-  top: 0;
-  right: 0;
+  top: $indicator-position;
+  right: $indicator-position;
   width: $indicator-size;
   height: $indicator-size;
   border-radius: 100%;
-  background-color: color('teal');
+  background-color: var(--p-highlight-icon, color('teal'));
+  border: solid 2px var(--p-surface-background, var(--top-bar-background));
 }