[TextField] Remove redundant null check #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
force-pushed
the
remove-redundant-condition
branch
from
208d23e to
ec0b0f9
Compare
chloerice
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Tophat works as expected 
Click to view collapsed Playground code
import React, {useState, useCallback} from 'react';
import {Page, TextField} from '../src';
interface TextFieldProps {
autocomplete?: boolean | string;
}
function TextFieldExample({autocomplete}: TextFieldProps) {
const [value, setValue] = useState('Jaded Pixel');
const handleChange = useCallback((newValue) => setValue(newValue), []);
return (
<TextField
autoComplete={autocomplete}
label="Store name"
value={value}
onChange={handleChange}
/>
);
}
export function Playground() {
return (
<Page title="Playground">
<TextFieldExample autocomplete />
<TextFieldExample />
<TextFieldExample autocomplete={undefined} />
<TextFieldExample autocomplete="off" />
</Page>
);
}This check is redundant, since it should already be covered by
else {
return autoComplete;
}
sambostock
force-pushed
the
remove-redundant-condition
branch
from
ec0b0f9 to
5a0a6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
There is a redundant
nullcheck in<TextField />'snormalizeAutocompletefunction. It should already be covered byWHAT is this pull request doing?
The redundant condition is removed.
🎩 checklist