[Color system] Convert colors to HSLuv #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💦 Potential splash zone of changes introduced to ❌ Something fishy happened. We’re on it! Error message:
TypeError: Cannot read property 'forEach' of undefined
This comment automatically updates as changes are made to this pull request. |
tmlayton
force-pushed
the
color-system/hsluv
branch
from
24fa4e6 to
faced85
Compare
tmlayton
force-pushed
the
color-system/hsluv
branch
from
1f4cd23 to
eaa9b45
Compare
|
I added a kitchen sink example. It’s still a WIP to cherry pick which of the stories we want to show. As of now it is filtering out any stories which match the |
tmlayton
force-pushed
the
color-system/hsluv
branch
2 times, most recently
from
2dd7c08 to
0142b1d
Compare
tmlayton
force-pushed
the
color-system/hsluv
branch
from
0142b1d to
911d7b9
Compare
|
|
Co-authored-by: Dan Rosenthal <dan.rosenthal@shopify.com>
tmlayton
force-pushed
the
color-system/hsluv
branch
from
8722d7c to
54e79d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Use a color space (HSLuv) which maintains human perceived lightness across hues. This is important to maintain color contrast regardless of hue. Also, tweaked colors, added shadow colors, and fixed an issue where types were not generated for the color JSON config.
WHAT is this pull request doing?
🎩 checklist