-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order detail route #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
reviewed
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COOL
Co-authored-by: Josh Larson <jplhomer@gmail.com>
remcolakens
added a commit
to remcolakens/hydrogen
that referenced
this pull request
Jul 14, 2023
## Context This pull request introduces a new component for defining aspect ratio and images ## Changes - Added a new package `@code-internet-applications/aspect-ratio` to handle aspect ratio functionality. - Implemented a new (hydrogen) component `<Image />` to handle custom images. - Implemented a new (hydrogen) component `<HydrogenImage />` to handle images from Shopify. ## Screenshot   ## Paperwork [SCH-75](https://codeinternetapplications.atlassian.net/browse/SCH-75) ## Checklist - [x] My code follows the style guidelines of this project - [x] I've performed a self-review of my own code - [x] I've added a changeset if this PR contains user-facing or noteworthy changes - [x] I've commented my code, particularly in hard-to-understand areas - [x] I've made corresponding changes to the documentation - [x] I've tested my code for breaking changes and added the corresponding footer in this PR if needed [SCH-75]: https://codeinternetapplications.atlassian.net/browse/SCH-75?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
remcolakens
added a commit
to remcolakens/hydrogen
that referenced
this pull request
Jul 14, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @code-internet-applications/aspect-ratio@0.1.0 ### Minor Changes - [Shopify#63](https://github.com/code-internet-applications/cbt-hydrogen/pull/63) [`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-75: add aspect ratio & image component ## @code-internet-applications/badge@0.2.0 ### Minor Changes - [Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64) [`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add product card - [Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58) [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added new radio buttons to match with the CBT design ## @code-internet-applications/card@0.1.0 ### Minor Changes - [Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64) [`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add product card ## @code-internet-applications/container@0.1.0 ### Minor Changes - [Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62) [`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add container component ## @code-internet-applications/label@0.2.0 ### Minor Changes - [Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58) [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added new radio buttons to match with the CBT design ## @code-internet-applications/price@0.1.0 ### Minor Changes - [Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64) [`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add product card - [Shopify#60](https://github.com/code-internet-applications/cbt-hydrogen/pull/60) [`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-36: add price styling ## @code-internet-applications/quantity-selector@0.1.0 ### Minor Changes - [Shopify#61](https://github.com/code-internet-applications/cbt-hydrogen/pull/61) [`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-35: add quantity selector ## @code-internet-applications/radio@0.1.0 ### Minor Changes - [Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58) [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added new radio buttons to match with the CBT design ## @code-internet-applications/react@0.4.0 ### Minor Changes - [Shopify#64](https://github.com/code-internet-applications/cbt-hydrogen/pull/64) [`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-27: add product card - [Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62) [`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add container component - [Shopify#61](https://github.com/code-internet-applications/cbt-hydrogen/pull/61) [`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-35: add quantity selector - [Shopify#60](https://github.com/code-internet-applications/cbt-hydrogen/pull/60) [`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-36: add price styling - [Shopify#63](https://github.com/code-internet-applications/cbt-hydrogen/pull/63) [`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-75: add aspect ratio & image component - [Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58) [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added new radio buttons to match with the CBT design ### Patch Changes - Updated dependencies \[[`94ee07f`](https://github.com/code-internet-applications/cbt-hydrogen/commit/94ee07fa32933c3145d2876ba6141639565e75da), [`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3), [`fe3cc29`](https://github.com/code-internet-applications/cbt-hydrogen/commit/fe3cc29e36b7dac027411905fc67e0a7c92d0143), [`cc39edd`](https://github.com/code-internet-applications/cbt-hydrogen/commit/cc39eddee2edd03d03b9b930343e093141943a84), [`65896a7`](https://github.com/code-internet-applications/cbt-hydrogen/commit/65896a76614c65c773824dba9fdf922275ab58d5), [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391), [`c33327a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/c33327a5e3d6107517dff5507c220ed1c9feb960)]: - @code-internet-applications/badge@0.2.0 - @code-internet-applications/price@0.1.0 - @code-internet-applications/card@0.1.0 - @code-internet-applications/container@0.1.0 - @code-internet-applications/quantity-selector@0.1.0 - @code-internet-applications/aspect-ratio@0.1.0 - @code-internet-applications/select@0.1.0 - @code-internet-applications/label@0.2.0 - @code-internet-applications/radio@0.1.0 ## @code-internet-applications/select@0.1.0 ### Minor Changes - [Shopify#58](https://github.com/code-internet-applications/cbt-hydrogen/pull/58) [`1368a2a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/1368a2a1daf50c12e752b301a3453b253269f391) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: Added new radio buttons to match with the CBT design - [Shopify#56](https://github.com/code-internet-applications/cbt-hydrogen/pull/56) [`c33327a`](https://github.com/code-internet-applications/cbt-hydrogen/commit/c33327a5e3d6107517dff5507c220ed1c9feb960) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-34: add new component for the Select styling ## @code-internet-applications/tailwind-config@0.4.0 ### Minor Changes - [Shopify#62](https://github.com/code-internet-applications/cbt-hydrogen/pull/62) [`e2cd2f6`](https://github.com/code-internet-applications/cbt-hydrogen/commit/e2cd2f6484d0dac9678dfa6d7e2ec675cf9863c3) Thanks [@remcolakens](https://github.com/remcolakens)! - SCH-103: add container component Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.