Skip to content

Commit

Permalink
Fix hydrogen init message for global cli (#2200)
Browse files Browse the repository at this point in the history
* Update package.json to use a newer cli-kit version if available, needed for bundling

* Show different message when creating a project from the global CLI

* Fix message after hydrogen init

* Rever package-lock changes

* Remove lock file commited by mistake

* Default init message to npm run dev if using global CLI
  • Loading branch information
isaacroldan authored Jun 6, 2024
1 parent 6baf36b commit a8b9c6c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/cli/src/lib/onboarding/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ import {
} from '../setups/routes/generate.js';
import {execAsync} from '../process.js';
import {getStorefronts} from '../graphql/admin/link-storefront.js';
import {currentProcessIsGlobal} from '@shopify/cli-kit/node/is-global';

export type InitOptions = {
path?: string;
Expand Down Expand Up @@ -699,7 +700,9 @@ export async function renderProjectReady(
? undefined
: `cd ${project.location.replace(/^\.\//, '')}`,
depsInstalled ? undefined : `${packageManager} install`,
formatPackageManagerCommand(packageManager, 'dev'),
currentProcessIsGlobal()
? 'npm run dev'
: formatPackageManagerCommand(packageManager, 'dev'),
]
.filter(Boolean)
.join(' && '),
Expand Down

0 comments on commit a8b9c6c

Please sign in to comment.