Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Operation class following the meeting with the quantum s… #26

Merged

Conversation

alexanderivrii
Copy link

…ynthesis team; adding tests to test_operation

Summary

Updating the Operation class based on the discussion with the quantum synthesis team and notes from Jake.

Adding tests to test operation that check:

  1. we can instantiate various classes that have Operation interface and they have the expected name, num_qubits and num_clbits.
  2. we can add such objects to a QuantumCircuit

Details and comments

The QuantumCircuit itself is still not an Operation, as we have agreed we will add this functionality when we get a use-case for that.

The soon-to-follow (but a different) PR will be to make LinearFunction of type Operation and not of type QuantumCircuit

…ynthesis team; adding tests to test_operation
@ShellyGarion ShellyGarion merged commit 7cb8a11 into ShellyGarion:circuit_element Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants