Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that the "find_element_by_* ..." warning is a deprecation warning #9700

Merged
merged 2 commits into from Aug 13, 2021
Merged

Conversation

LeonShams
Copy link
Contributor

@LeonShams LeonShams commented Jul 30, 2021

Description

Specify that the "find_element_by_* ..." warning is a deprecation warning just like all the other deprecation warnings.

Motivation and Context

This change means that the warning will be suppressed with all other deprecation warnings when filterwarnings is called for DeprecationWarning.

The following is a demonstration of the issue

>>> warnings.filterwarnings("ignore", category=DeprecationWarning)
>>> driver.find_element_by_id("id")
<stdin>:1: UserWarning: find_element_by_* commands are deprecated. Please use find_element() instead

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #9700 (f3565ae) into trunk (bfce42b) will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9700      +/-   ##
==========================================
+ Coverage   43.99%   44.48%   +0.48%     
==========================================
  Files          83       83              
  Lines        5441     5489      +48     
  Branches      245      245              
==========================================
+ Hits         2394     2442      +48     
  Misses       2802     2802              
  Partials      245      245              
Impacted Files Coverage Δ
py/selenium/webdriver/remote/webdriver.py 39.47% <100.00%> (+5.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279f0d6...f3565ae. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 72ffec9 into SeleniumHQ:trunk Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants