[py] PEP 484 type hints for selenium.webdriver.remote.utils #9525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoefling
commented
May 27, 2021
|
|
||
|
|
||
| LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def format_json(json_struct): | ||
| def format_json(json_struct: Any) -> str: |
There was a problem hiding this comment.
@AutomatedTester looks like this function is unused.
hoefling
commented
May 27, 2021
| return json.loads(s) | ||
|
|
||
|
|
||
| def unzip_to_temp_dir(zip_file_name): | ||
| def unzip_to_temp_dir(zip_file_name: Path) -> Optional[str]: |
There was a problem hiding this comment.
@AutomatedTester this function seems to be unused as well.
|
If there are methods that are not used then let's delete them. |
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
hoefling
force-pushed
the
PEP-484/webdriver-remote-utils
branch
from
82b2962 to
d2115fd
Compare
|
@AutomatedTester done, please review again! |
AutomatedTester
approved these changes
Jun 16, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds type hints to
selenium.webdriver.remote.utils.Motivation and Context
This is a follow-up of #9482 to address #9480.
Types of changes
Checklist