[grid] Remove old Grid tests since features exist in current Grid #9400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Remove old Grid tests since features exist in current Grid
Motivation and Context
LoadBalancedTest
Feature: Incoming test should be load-balanced among all the Nodes in the Grid
Details:
In Grid 4 the Distributor identifies the Node for new incoming session request. This Node selection is done here: https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/distributor/selector/DefaultSlotSelectorTest.java
While selecting the Node, the Node’s load is also considered.
Test: https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/distributor/DistributorTest.java#L496
NewRequestCrashesDuringNewSessionTest
Feature: New session creation error should not lead to an inconsistent state in the Grid
Details:
If any error happens while creating a new session request, the error is propagated back to the Distributor and depending on the error, the request is either retried or rejected. In case the request is retried, it will be retried up to a certain timelimit then rejected. Similarly, if the request sits in the new session request queue and the Grid is facing any issue in polling the session, the timed-out requests are removed from the queue.
Tests:
https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/router/SessionQueueGridTest.java
https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/router/NewSessionCreationTest.java#L158
RemoteProxySlowSetup
Feature: Multiple time if the same node is registered, then it is counted as one.
Grid 3 :
Any new incoming node registers itself with the Hub. If two same nodes (same configuration) register to the Hub, only one node registers itself.
Grid 4 :
Same as Grid 3
Test:
https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/distributor/DistributorTest.java#L480
SessionTimesoutTest
Feature: Remove any inactive session after a configured time period. Poll all nodes at regular intervals (configurable) and remove inactive Nodes.
Grid 3 :
timeout - Configurable flag for removing inactive session. If the session is inactive for more than that time, the session is removed from the Grid and frees up the slot.
cleanUpCycle - Hub polls all the Node at regular interval and removes inactive Node.
Grid 4 :
Same as Grid 3
session - timeout - Configurable flag for removing inactive session. If the session is inactive for more than that time, the session is removed from the Grid and frees up the slot.
heartBeat-period - Hub polls all the Node at regular interval and removes inactive Node.
SmokeTest
Grid 3 :
Test to check end to end functionality of the Grid for 10 tests.
Grid 4 :
Covered in
https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/router/EndToEndTest.java
https://github.com/SeleniumHQ/selenium/blob/trunk/java/server/test/org/openqa/selenium/grid/router/StressTest.java
Since the features described above are present in Grid 4. It is safe to remove the tests.
Types of changes
Checklist