-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Python type hints #9192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had left those because the methods are deprecated but we can add it for now and then once Selenium 4 is released we will be deleting them
@AutomatedTester Where can I give a look at the new methods in Selenium 4? |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all the find_elements
(plural) methods should return list[WebElement]
and not WebElement
Am I mistaken?
Should I open a separate PR for this?
Description
I wasn't able to get the right suggestion for the code completion using pylance in vs code. That's why I started adding a few lines to improve the suggestions
Motivation and Context
I made these changes because I was working on a personal project and having those "type hints" really helped me
Types of changes
I only changed a few lines adding type hints. If this kind of changes are welcomed I'll continue to update the hints in the future when I use selenium and I need it
Checklist