Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Python type hints #9192

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Additional Python type hints #9192

merged 4 commits into from
Mar 1, 2021

Conversation

AlbertoCentonze
Copy link
Contributor

@AlbertoCentonze AlbertoCentonze commented Feb 18, 2021

Description

I wasn't able to get the right suggestion for the code completion using pylance in vs code. That's why I started adding a few lines to improve the suggestions

Motivation and Context

I made these changes because I was working on a personal project and having those "type hints" really helped me

Types of changes

I only changed a few lines adding type hints. If this kind of changes are welcomed I'll continue to update the hints in the future when I use selenium and I need it

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@AutomatedTester AutomatedTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had left those because the methods are deprecated but we can add it for now and then once Selenium 4 is released we will be deleting them

@AlbertoCentonze
Copy link
Contributor Author

@AutomatedTester Where can I give a look at the new methods in Selenium 4?

@AlbertoCentonze AlbertoCentonze marked this pull request as ready for review February 28, 2021 18:41
@AutomatedTester AutomatedTester merged commit 4024861 into SeleniumHQ:trunk Mar 1, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@hudcap hudcap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all the find_elements (plural) methods should return list[WebElement] and not WebElement
Am I mistaken?
Should I open a separate PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants