Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'webview2' browser name for Edge python options #9090

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

bwalderman
Copy link
Contributor

Description

Fixing the casing of the browserName capability for Edge WebView2. It should be webview2.

Motivation and Context

The previous spelling was a typo. MsEdgeDriver expects the capability to match webview2 (case sensitive). This was already fixed for C# in #8455.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AutomatedTester
Copy link
Member

Thank you for the patch

@AutomatedTester AutomatedTester merged commit 7b42f86 into SeleniumHQ:trunk Jan 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants