Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Added from .common.keys import Keys (same as selenium.webdriver.common.keys.Keys) #9076

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

shreyanavigyan
Copy link
Contributor

@shreyanavigyan shreyanavigyan commented Jan 20, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

After this change we can simply import the Keys by running,

selenium.webdriver import Keys

Instead of,

from selenium.webdriver.common.keys import Keys

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…n.keys.Keys)

Added from .common.keys import Keys (same as selenium.webdriver.common.keys.Keys)
…n.keys.Keys)

Added from .common.keys import Keys (same as selenium.webdriver.common.keys.Keys)
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2021

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shreyanavigyan shreyanavigyan changed the title Added from .common.keys import Keys (same as selenium.webdriver.common.keys.Keys) [py] Added from .common.keys import Keys (same as selenium.webdriver.common.keys.Keys) Jan 21, 2021
@shreyanavigyan
Copy link
Contributor Author

Hi,
Some Tests are failing though I've not changed the files or anything in other Programming Languages other than Python. All the Python Tests are successful but I don't know why Java and Ruby Tests failed since I've not tampered with those. I'd like to request a review of my pull request and kindly ignore the failed Java and Ruby Tests since those are not changed but still failing (it's a bug). Thanking you,

With Regards

@AutomatedTester AutomatedTester merged commit 5630155 into SeleniumHQ:trunk Jan 21, 2021
@AutomatedTester
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants