[grid] Add new session request queue size endpoint and GraphQL support #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pujagani
force-pushed
the
newsessionqueue_count
branch
from
728c127 to
59581a5
Compare
diemol
reviewed
Jan 7, 2021
There was a problem hiding this comment.
@pujagani, why don't we use the count from the requestIds queue in the Distributor?
Or, if the idea is to use the NewSessionQueuer, probably it is a good idea to expose the capabilities of the tests in the queue. With that, users can decide what type of infrasturcture to scale. Only with a number, they do not know if the tests in the queue are requesting Firefox, Chrome or Safari.
pujagani
force-pushed
the
newsessionqueue_count
branch
from
fa0227d to
ee8dad3
Compare
pujagani
force-pushed
the
newsessionqueue_count
branch
from
ee8dad3 to
3512fa0
Compare
|
SonarCloud Quality Gate failed. |
diemol
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Related to #9024. Exposing the new session queue size via an endpoint and GraphQL.
Motivation and Context
As mentioned in #9024, it will help users to scale nodes and get information regarding the pending new session requests. A quick way to get the queue size would be using an endpoint directly. The Grid supports GraphQL for richer querying support, the changes add the new session request queue count to the GraphQL schema.
Types of changes
Checklist