Update toJson() method creation for integer type in CdpClientGenerator. #8997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Related to #8871. Fixes toJson() method's return type for integer parameters.
Motivation and Context
Sending the Cdp command using websocket requires the request to be serialized into Json string, and for this toJson() method of WindowID is used. The CdpClientGenerator generates classes based on the browser_protocol.
While creating WindowID class, the return type for toJson() method was String. As a result following error was received anytime WindowID was used,
WARNING: Unhandled type: {"id":6,"error":{"code":-32602,"message":"Invalid parameters","data":"Failed to deserialize params.windowId - BINDINGS: int32 value expected at position 16"}}
.The changes fix the serialization issue by ensuring Integer return type is added.
Types of changes
Checklist