Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Adding support for computedrole #8990

Merged
merged 3 commits into from
Jan 3, 2021
Merged

[JS] Adding support for computedrole #8990

merged 3 commits into from
Jan 3, 2021

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Dec 22, 2020 •
edited
Loading

Description

Adding support for computedrole

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509
Copy link
Member Author

harsha509 commented Dec 28, 2020 •
edited
Loading

@corevo When time permits could you please review this PR

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@corevo corevo merged commit 27fe2d9 into SeleniumHQ:trunk Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corevo corevo corevo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha509 @corevo