Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for float types in text fields #8936

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Support for float types in text fields #8936

merged 2 commits into from
Dec 7, 2020

Conversation

naveensingh
Copy link
Contributor

TypeError: object of type 'float' has no len()

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Added support for float types when converting keys to list in the keys_to_typing method

Motivation and Context

The current implementation raises "TypeError: object of type float has no len()" when a float value is passed to the send_keys method which in turn calls keys_to_typing which calls range(len(value)) on every type other than int

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x ] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

TypeError: object of type 'float' has no len()
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2020

CLA assistant check
All committers have signed the CLA.

@AutomatedTester
Copy link
Member

Thanks for the PR!

@AutomatedTester AutomatedTester merged commit b9b4da5 into SeleniumHQ:trunk Dec 7, 2020
@naveensingh naveensingh deleted the patch-1 branch December 7, 2020 10:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2020

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants