-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add log level mapping for ChromeDriver #8242
Add log level mapping for ChromeDriver #8242
Conversation
4cc499a
to
bcfece4
Compare
2fa4125
to
a65845d
Compare
487b76b
to
05a8676
Compare
This chromedriver logging page will need updating, how do I go about that? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's shaping up perfectly. Thank you for doing this. Just a couple of points, and we'll merge and land. :)
java/client/src/org/openqa/selenium/chrome/ChromeDriverService.java
Outdated
Show resolved
Hide resolved
java/client/src/org/openqa/selenium/chrome/ChromeDriverService.java
Outdated
Show resolved
Hide resolved
Add check for CHOME_DRIVER_LOG_LEVEL_PROPERTY and have that take precedence if set.
05a8676
to
f009269
Compare
@shs96c requested changes have been made. Kindly review at your convenience. Many thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
Merged into the tree. Thank you once again! |
Add log level mapping for ChromeDriver. Adds check for `CHOME_DRIVER_LOG_LEVEL_PROPERTY` and have that take precedence if set.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This will enable setting ChromeDriver log level via ChromeOption.
This removes the need for this line of code
System.setProperty("webdriver.chrome.verboseLogging", true)
Set Logging like so:
ChromeOptions options = new ChromeOptions();
options.setLogLevel(ChromeDriverLogLevel.ALL)
Motivation and Context
Fixes #7493
Makes adapting to future w3c spec on logging easy to manage.
Types of changes
Checklist