Support functions for message in driver.wait() #8094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Supporting functions for
message
indriver.wait()
.Description
This change allows users to pass a function that resolves an error message when the
driver.wait()
condition fails. Currently astring
can be passed to thewait()
method, now() => string
can also be passed.Motivation and Context
Currently a user only has the ability to pass a message containing information about the step at the beginning of the test. Giving a user the ability to pass a function that resolves a message allows the message to contain information that is made available at the end of the test. The motivation for this PR is to be able to write out information about the current state of the test results after a timeout period has expired.
Types of changes
Checklist