Fix erro in webelemet not created, verifing if is str or dict.

[reinaldorossetti]

• By placing an X in the preceding checkbox, I verify that I have signed the Contributor License Agreement

---

This change is 

[reinaldorossetti]

Fix error in webelemet not created, verifing if is str or dict. Tested in Firefox 51.0.1 e Chrome 55.

[isaulv]

This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.

[reinaldorossetti]

I have problem because element not is webelement is str in firefox and dict in chrome.

[reinaldorossetti]

<selenium.webdriver.remote.webelement.WebElement (session="49274937103ea6cd11bc1c9a3a4784ee", element="0.9158218795761794-1")>
<selenium.webdriver.remote.webelement.WebElement (session="49274937103ea6cd11bc1c9a3a4784ee", element="0.9158218795761794-2")>
Traceback (most recent call last):
File "D:\Dropbox\Dropbox\Meu Curso de Selenium\testes\loading_page.py", line 30, in
test = wait_element_not_present(driver, ".loadingoverlay")
File "D:\Dropbox\Dropbox\Meu Curso de Selenium\testes\loading_page.py", line 20, in wait_element_not_present
expected_conditions.invisibility_of_element_located((By.CSS_SELECTOR, elem))
File "C:\Python35-32\lib\site-packages\selenium\webdriver\support\wait.py", line 71, in until
value = method(self._driver)
File "C:\Python35-32\lib\site-packages\selenium\webdriver\support\expected_conditions.py", line 198, in call
return _element_if_visible(_find_element(driver, self.locator), False)
File "C:\Python35-32\lib\site-packages\selenium\webdriver\support\expected_conditions.py", line 100, in _element_if_visible
return element if element.is_displayed() == visibility else False
AttributeError: 'dict' object has no attribute 'is_displayed'

[isaulv]

How is that happening? That function is a 'private' function that should only be called when there's an element to examine from the public expected condition functions.

[reinaldorossetti]

This InvalidSelectorException not work because function need return true, do you look exception:

class invisibility_of_element_located(object):
""" An Expectation for checking that an element is either invisible or not
present on the DOM.

locator used to find the element
"""
def __init__(self, locator):
    self.locator = locator

def __call__(self, driver):
    try:
        return _element_if_visible(_find_element(driver, self.locator), False)
    except (NoSuchElementException, StaleElementReferenceException):
        # In the case of NoSuchElement, returns true because the element is
        # not present in DOM. The try block checks if the element is present
        # but is invisible.
        # In the case of StaleElementReference, returns true because stale
        # element reference implies that element is no longer visible.
        return True

[reinaldorossetti]

It is string.

[reinaldorossetti]

How do you test if I'm wrong or right? How should I make the above code work?

[isaulv]

I've tested the code you wrote on a simple web page. What you wrote seems like it should work, except in the case of waiting for an element to go 'invisible' you should not care about the result (The result will be True for invisibility). Maybe you should go to the #selenium chat room on freenode IRC and ask for help there.

[reinaldorossetti]

This problem only happen in invisibility_of_element_located, no have problem that return true or false, but the problem is that it throws an exception in the code and stop my test.

[reinaldorossetti]

How do I know if the problem came from chrome or firefox? How do I test this?

[isaulv]

I don't think this is the right level to put a type check; what problem are you trying to solve?
Also I wouldn't check on particular types, I would check if the variable element is not of instance WebElement.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AutomatedTester
❌ reinaldorossetti
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[isaulv]

@AutomatedTester I don't think this should have been merged. Clearly the function expects a web element type to have the is displayed function and it throws an exception. Either we add type checking for all expected condition functions for consistency and safety, or let python do its thing.

That being said I have seen cases were Chrome or Firefox does not return a proper WebElement object but that's probably a bug in the driver.