Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Revert deprecation of GetAttribute method #14956

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Dec 27, 2024

User description

Description

It reverts GetAttribute deprecation for .NET

Motivation and Context

To be aligned with all bindings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Reverts the deprecation of the GetAttribute method across the .NET binding
  • Removes Obsolete attribute from GetAttribute method in three key classes:
    • EventFiringWebDriver
    • IWebElement interface
    • WebElement class
  • Maintains alignment with other Selenium bindings by keeping GetAttribute as a supported method

Changes walkthrough 📝

Relevant files
Enhancement
EventFiringWebDriver.cs
Remove GetAttribute deprecation in EventFiringWebDriver   

dotnet/src/support/Events/EventFiringWebDriver.cs

  • Removed the Obsolete attribute from the GetAttribute method in the
    EventFiringWebDriver class
  • +0/-1     
    IWebElement.cs
    Remove GetAttribute deprecation in IWebElement interface 

    dotnet/src/webdriver/IWebElement.cs

  • Removed the Obsolete attribute from the GetAttribute method in the
    IWebElement interface
  • +0/-1     
    WebElement.cs
    Remove GetAttribute deprecation in WebElement class           

    dotnet/src/webdriver/WebElement.cs

  • Removed the Obsolete attribute from the GetAttribute method in the
    WebElement class
  • +0/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko nvborisenko merged commit 44e16ca into SeleniumHQ:trunk Dec 27, 2024
    10 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant